Skip to content

Improve help text of user key of provision plugins#4904

Open
happz wants to merge 1 commit into
mainfrom
document-user-key-better
Open

Improve help text of user key of provision plugins#4904
happz wants to merge 1 commit into
mainfrom
document-user-key-better

Conversation

@happz
Copy link
Copy Markdown
Contributor

@happz happz commented May 19, 2026

The current text is very wide-reaching, this patch makes it more precise and describes what effects it has.

Pull Request Checklist

  • implement the feature

@happz happz added this to planning May 19, 2026
@happz happz added documentation Improvements or additions to documentation step | provision Stuff related to the provision step code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels May 19, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning May 19, 2026
@happz happz added the ci | full test Pull request is ready for the full test execution label May 19, 2026
@happz happz moved this from backlog to review in planning May 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the help documentation for the user option in both the SSH guest data and Podman provisioner to clarify how the username is used and how it interacts with the become setting. I have no feedback to provide.

@happz happz self-assigned this May 21, 2026
@thrix thrix self-requested a review May 26, 2026 10:37
Copy link
Copy Markdown
Contributor

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing to comment on.

@happz happz moved this from review to merge in planning May 26, 2026
The current text is very wide-reaching, this patch makes it more precise
and describes what effects it has.
@therazix therazix force-pushed the document-user-key-better branch from f780d18 to 5793f16 Compare May 27, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. documentation Improvements or additions to documentation step | provision Stuff related to the provision step

Projects

Status: merge

Development

Successfully merging this pull request may close these issues.

3 participants